Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable skipped SSC.Algorithms tests on Andorid #56573

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

steveisok
Copy link
Member

DSAKeyGeneration.GenerateSecondMinKey and DSAKeyGeneration.GenerateMinKey no longer fail. Added validation in RSAAndroid.cs to make RSAXml.FromNonsenseXml pass.

Fixes #50580
Fixes #50581

DSAKeyGeneration.GenerateSecondMinKey and DSAKeyGeneration.GenerateMinKey no longer fail.  Added validation in RSAAndroid.cs to make RSAXml.FromNonsenseXml pass.

Fixes dotnet#50580
Fixes dotnet#50581
@ghost
Copy link

ghost commented Jul 29, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

DSAKeyGeneration.GenerateSecondMinKey and DSAKeyGeneration.GenerateMinKey no longer fail. Added validation in RSAAndroid.cs to make RSAXml.FromNonsenseXml pass.

Fixes #50580
Fixes #50581

Author: steveisok
Assignees: -
Labels:

area-System.Security

Milestone: -

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nit with the comment. Also check if the FromNonsenseXml test passes on OSX as the validation is only on Android's side.

Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the comment about CNG behavior

…id.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the pending comment, LGTM.

@steveisok steveisok merged commit b2e483e into dotnet:main Jul 30, 2021
@steveisok steveisok deleted the enable-skip-crypto-tests branch July 30, 2021 17:46
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants