Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BufferedStream outerloop test #56618

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

MihaZupan
Copy link
Member

The tests added in #53338 use [InlineData] and [ConditionalFact] instead of theory. This is failing all System.IO outerloop runs. Example console.log

@MihaZupan MihaZupan added this to the 6.0.0 milestone Jul 30, 2021
@MihaZupan MihaZupan requested a review from jeffhandley July 30, 2021 12:18
@ghost
Copy link

ghost commented Jul 30, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

The tests added in #53338 use [InlineData] and [ConditionalFact] instead of theory. This is failing all System.IO outerloop runs. Example console.log

Author: MihaZupan
Assignees: -
Labels:

area-System.IO

Milestone: 6.0.0

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing it @MihaZupan !

@stephentoub stephentoub merged commit 8190713 into dotnet:main Jul 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants