Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable MacCatalyst Arm64 crashing test suites #56625

Merged
merged 7 commits into from
Aug 6, 2021

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 30, 2021

Evaluating the state of flakey test suite crashes #53813

1: no failures
2: no failures
3: no failures
4: no failures (but noticed that System.Diagnostics.DiagnosticSource.Switches.Tests had 0 tests due to ActiveIssue at class level)
5: no failures (Remove MacCatalyst Skip instead of Android skip for System.Diagnostics.DiagnosticSource.Switches.Tests)
6: no failures

From several test runs of MacCatalyst arm64 of the crashing test suites in #53813, none were found to be crashing anymore, so its suspected that a fix had made it in.

This PR looks to re-enable those test suites to be ran on MacCatalyst arm64 and to combine the Active Issues for Android and iOS/tvOS into one as they have the same failure.

Fixes #53813

System.Diagnostic.DiagnosticSource.Switches.Tests is re-enabled in #56737

@mdh1418 mdh1418 added the NO-REVIEW Experimental/testing PR, do NOT review it label Jul 30, 2021
@mdh1418 mdh1418 marked this pull request as ready for review August 2, 2021 21:29
@mdh1418
Copy link
Member Author

mdh1418 commented Aug 2, 2021

The lanes are stalling on GitHub UI, but in AzDo, the failures are unrelated.

@mdh1418 mdh1418 removed the NO-REVIEW Experimental/testing PR, do NOT review it label Aug 4, 2021
@mdh1418 mdh1418 changed the title Run just MacCatalyst Arm64 crashing test suites Reenable MacCatalyst Arm64 crashing test suites Aug 5, 2021
@steveisok steveisok merged commit ce3447c into dotnet:main Aug 6, 2021
@steveisok steveisok deleted the android_arm64_check_crashing_suites branch August 6, 2021 13:29
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MacCatalyst][libraries] Test suites flake with App Launch Failure on CI
2 participants