[hot_reload] Allow benign Param table updates #56800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
approved these changes
Aug 3, 2021
as long as the param name and sequence number stays the same, the edit is allowed.
lambdageek
force-pushed
the
benign-param-updates
branch
from
386dc5f to
81bf189
Compare
lewing
reviewed
Aug 4, 2021
| @@ -39,6 +39,33 @@ void StaticMethodBodyUpdate() | |||
| }); | |||
| } | |||
|
|
|||
| [ConditionalFact(typeof(ApplyUpdateUtil), nameof (ApplyUpdateUtil.IsSupported))] | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/54617", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] | |||
There was a problem hiding this comment.
Is this wasm aot specific or should it be disabled on all mono aot?
There was a problem hiding this comment.
It's not going to work on any Mono AOT configuration - but ApplyUpdateUtil.IsSupported is already ruling out all the others.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the body of a lambda, Roslyn emits a Param table update for the parameters of the lambda even if nothing about the parameter changed. This is by design.
Update mono method body replacement to allow these benign updates (and ignore them). As long as the sequence number and parameter name are the same as previously, we allow it.
This enables Mono to apply updates to lambda bodies and to their enclosing methods. This does not allow new lambdas to be added to a method body. This does not allow for method signatures to change, or for parameter renaming.
Note: this PR also bumps
hotreload-utils, which picks up changes from Roslyn necessary to generate nice deltas.Fixes #56574, part of #44806