Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete Rfc2898DeriveBytes.CryptDeriveKey #57002

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Aug 6, 2021

Contributes to #50528.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 6, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 6, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #50528.

Author: vcsjones
Assignees: -
Labels:

area-System.Security, new-api-needs-documentation, community-contribution

Milestone: -

@vcsjones vcsjones added this to the 6.0.0 milestone Aug 6, 2021
@vcsjones
Copy link
Member Author

vcsjones commented Aug 6, 2021

Skipping API Review and setting for 6.0 per #50528 (comment).

@vcsjones
Copy link
Member Author

vcsjones commented Aug 6, 2021

Test failures are #56926 and #56894.

@jeffhandley jeffhandley added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed new-api-needs-documentation labels Aug 6, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 6, 2021
@ghost

This comment has been minimized.

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
@jeffhandley
Copy link
Member

Breaking change document issue created: dotnet/docs#25506

@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 6, 2021
@danmoseley danmoseley merged commit c5faf00 into dotnet:main Aug 12, 2021
@vcsjones vcsjones deleted the obsolete-cryptderivekey branch August 12, 2021 03:42
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants