Make JsonGenerator be an incremental generator

[chsienki]

No description provided.

[ghost]

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	chsienki
Assignees:	-
Labels:	area-System.Text.Json
Milestone:	-

[jkoritzinsky]

It might also be interesting to look at moving the EventSource generator to be an incremental generator as that one is currently internal-only and doesn't ship outside the repo. As a result, that generator can move to the incremental APIs before a cross-targeting story for generators is finalized.

[steveharter]

Is #58068 going to be merged first? (some overlap)

[steveharter]

I assume the CI failures in STJ.SourceGeneration.Unit.Tests (due to the commit here that enabled the src-gen tests to run) will be addressed in this PR.

[eerhardt]

Is #58068 going to be merged first? (some overlap)

They are going to go in at roughly the same time. The overlap in Versions.props should merge cleanly since they are identical changes.

I assume the CI failures in STJ.SourceGeneration.Unit.Tests (due to the commit here that enabled the src-gen tests to run) will be addressed in this PR.

Yes, fixing. The issue is that CI runs a few legs in Spanish, and this test was checking for hard-coded English strings.

[steveharter]

FWIW this change under the condition:

<ItemGroup Condition="'$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true'">

[eerhardt]

I'm not sure I understand the comment.

There are different levels of "exclude a test for wasm". This ItemGroup excludes the test for all WASM. The next group down excludes the test for "AOT" and "EnableAggressiveTrimming" WASM legs.

[steveharter]

Just adding a note since the raw github view here doesn't show the parent condition (since it is too far above). May save someone from opening the .cs file and manually finding that LOC.

[eerhardt]

/backport to release/6.0-rc1

[github-actions]

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1174954271

[github-actions]

@eerhardt backporting to release/6.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Make JsonGenerator be an incremental generator
Using index info to reconstruct a base tree...
M	eng/Versions.props
M	src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
M	src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
M	src/libraries/System.Text.Json/gen/JsonSourceGenerator.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Text.Json/gen/JsonSourceGenerator.cs
CONFLICT (content): Merge conflict in src/libraries/System.Text.Json/gen/JsonSourceGenerator.cs
Auto-merging src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
Auto-merging src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
Auto-merging eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Make JsonGenerator be an incremental generator
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!