-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Minor cleanups for System.Runtime.Numerics (#53984)" #57297
Conversation
This reverts commit 65439de.
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis resolves #57293
|
Thanks, @tannergooding. |
Did some brief additional investigation and it looks like the only changes that really need to be reverted are the ones using C# indexing expressions. The fixes to use I'm leaning towards leaving them out of .NET 6 anyways and letting them back in for .NET 7 but would appreciate hearing from @stephentoub first. |
I'm ok with either option. If you're confident the regression will go away just by reverting the indexing expression changes, great. If you want to back it all out and we can try again after we fork for .NET 7, great. |
Here is a comparison of the three. The biggest callouts are There look to be a couple of small regressions with the change still but its not clear if that's due to noise or not (they are within the error range, which is fairly large and it fluxuates a bit across separate runs). Revert Everything
Revert Only Index
Revert Nothing
|
This resolves #57293