Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group 3] Enable nullable annotations for Microsoft.Extensions.FileProviders.Physical #57409

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Aug 14, 2021

Related to #43605

Annotated according to:

Issue to fix implementation issues: #57518

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 14, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 14, 2021

Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

Annotated according to #57405

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-FileSystem, community-contribution

Milestone: -

@maxkoshevoi maxkoshevoi changed the title Enable nullable annotations for Microsoft.Extensions.FileProviders.Physical [Group 3] Enable nullable annotations for Microsoft.Extensions.FileProviders.Physical Aug 15, 2021
@adamsitnik adamsitnik added this to the 7.0.0 milestone Aug 16, 2021
@adamsitnik adamsitnik merged commit 4f5c20a into dotnet:main Aug 25, 2021
@maxkoshevoi maxkoshevoi deleted the mk/43605-FileProviders-Physical branch August 25, 2021 19:48
dougbu added a commit to dotnet/aspnetcore that referenced this pull request Aug 28, 2021
- handle Microsoft.Extensions.FileProviders.Abstractions nullability annotations (dotnet/runtime#57405)
- handle Microsoft.Extensions.FileProviders.Physical nullability annotations (dotnet/runtime#57409)
- !fixup! improve `HttpConnectionDispatcher.GetConnectionToken(...)` and its use
dotnet-maestro bot added a commit to dotnet/aspnetcore that referenced this pull request Aug 29, 2021
[main] Update dependencies from dotnet/efcore dotnet/runtime


 - Respond to nullable annotations of `StringSegment`
- general assumption is we don't create `StringValues` w/ `null` entries
- in addition, `StringSegment.IsNullOrEmpty(StringSegment)` doesn't seem to help the compiler

 - !fixup!

 - Handle more nullable expressions
- mostly about nullability annotations in `StringValues` and `StringSegment`
- see dotnet/runtime#58223 for info about the `StringValues` -> `string` implicit conversion

 - Merge branch 'main' into darc-main-fcbf8a54-42e6-4ded-9535-034b26dfd6ba

 - Latest nullability updates
- handle Microsoft.Extensions.FileProviders.Abstractions nullability annotations (dotnet/runtime#57405)
- handle Microsoft.Extensions.FileProviders.Physical nullability annotations (dotnet/runtime#57409)
- !fixup! improve `HttpConnectionDispatcher.GetConnectionToken(...)` and its use

 - Remove some `StringSegment.Value` `null` forgiveness and extra handling
- e.g. `ResponseCompressionProvider` used `StringSegment.Value` when a `string` constant would do
- also, `MediaTypeHeaderValue.Charset` getter unnecessarily did `StringSegment` -> `string` -> `StringSegment`
- also, `CookieHeaderParserShared` ignored `[NotNullWhen(true)]` attributes in helper

 - !fixup! Handle `IsNullOrEmpty(...)` metadata lack

 - !fixup! Use `ToString()` instead of suppression

 - Update `KnownHeaders`
- then regenerate HttpHeaders.Generated.cs

 - Do generated JS files need to change?

 - !fixup! Allow `Charset` to be `null`

 - !fixup! Adjust to fix failing tests
- note `HttpResponse.ContentType` type now matches `HttpRequest.ContentType`

 - !fixup! React to `HttpResponse.ContentType` change
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-FileSystem community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants