Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solution files for correct ordering of elements #58655

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

ViktorHofer
Copy link
Member

With the newest udpate of slngen, the order of elements (configuration, folders, etc.) is in sync with how Visual Studio arranges them. Also the order is now deterministic.

Based on that, updating all solution files to have the correct ordering of elements. This change also unblocks adding CI protection for making sure that solution files are up-to-date in regards to their dependencies as slngen is now generating the files deterministically.

I would not suggest to review the changes. Those are generated via invoking dotnet build src\libraries\slngen.proj.

With the newest udpate of slngen, the order of elements (configuration, folders, etc.) is in sync with how Visual Studio arranges them.
Also the order is now deterministic.

Based on that, updating all solution files to have the correct ordering of elements. This change also unblocks adding CI protection for
making sure that solution files are up-to-date in regards to their dependencies as slngen is now generating the files deterministically.
@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

With the newest udpate of slngen, the order of elements (configuration, folders, etc.) is in sync with how Visual Studio arranges them. Also the order is now deterministic.

Based on that, updating all solution files to have the correct ordering of elements. This change also unblocks adding CI protection for making sure that solution files are up-to-date in regards to their dependencies as slngen is now generating the files deterministically.

I would not suggest to review the changes. Those are generated via invoking dotnet build src\libraries\slngen.proj.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member Author

Merging. None of the files touched are actually exercised in CI (yet). I plan to add protection for solution files via a runtime-dev-innerloop leg.

@ViktorHofer ViktorHofer merged commit 36b6247 into dotnet:main Sep 3, 2021
@ViktorHofer ViktorHofer deleted the UpdateSlnGen branch September 3, 2021 22:16
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants