Fix Unix ARM floating point registers unwinding #58915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two problems unwinding ARM floating point registers. One is that the PAL_VirtualUnwind is not supporting that and the second is that the libunwind we carry and use actually doesn't have support for unwinding those. This change updates the libunwind so that both exidx and dwarf ways of unwinding can unwind these registers and also adds support to our PAL_VirtualUnwind to copy the callee saved floating point registers D8..D15 between the native and windows style contexts. I am planning to make a PR for the libunwind upstream, but given the very low amount of time we have remaining for .NET 6 completion, I am making the change here first. Once I get them upstream later, I'll update the whole libunwind from there.
janvorli
force-pushed
the
fix-arm32-float-unwind
branch
from
74bf015 to
791bf92
Compare
davidwrighton
approved these changes
Sep 10, 2021
|
Right. I might need to give it some little massage before pushing it upstream, but for our purposes, it is sufficient. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems unwinding ARM floating point registers. One is that the PAL_VirtualUnwind
is not supporting that and the second is that the libunwind we carry and use actually doesn't
have support for unwinding those.
This change updates the libunwind so that both exidx and dwarf ways of unwinding can unwind
these registers and also adds support to our PAL_VirtualUnwind to copy the callee saved
floating point registers D8..D15 between the native and windows style contexts.
I am planning to make a PR for the libunwind upstream, but given the very low amount of time
we have remaining for .NET 6 completion, I am making the change here first. Once I get them
upstream later, I'll update the whole libunwind from there.
Close #57040