Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from 4 repositories #58999

Merged
merged 6 commits into from
Sep 20, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 12, 2021

This pull request updates the following dependencies

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Subscription: d3a5b203-1393-4534-5b62-08d8d8feb47e
  • Build: 20210912.2
  • Date Produced: 9/12/2021 2:52 PM
  • Commit: d097f81586afd81fbc7350fc15b374aa173f7cb2
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 772acd8f-b0cb-4d38-9377-08d8d8ff2d75
  • Build: 20210913.1
  • Date Produced: 9/13/2021 10:11 AM
  • Commit: 0becd27
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20210912.1
  • Date Produced: 9/13/2021 12:42 AM
  • Commit: 476db4296eb1f83cf68473f9e6d173570db6cb5f
  • Branch: refs/heads/main

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20210913.4
  • Date Produced: 9/13/2021 5:12 PM
  • Commit: 4b7c80f398fd3dcea03fdc4e454789b61181d300
  • Branch: refs/heads/main

…otnet-optimization build 20210911.4

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21460.6 -> To Version 1.0.0-prerelease.21461.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Sep 12, 2021
…0913.1

Microsoft.NETCore.ILAsm , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.App.Runtime.win-x64 , runtime.native.System.IO.Ports , Microsoft.NET.Sdk.IL , System.Runtime.CompilerServices.Unsafe , System.Text.Json
 From Version 7.0.0-alpha.1.21456.1 -> To Version 7.0.0-alpha.1.21463.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dnceng/internal/dotnet-optimization [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/runtime Sep 13, 2021
…otnet-optimization build 20210912.2

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21460.6 -> To Version 1.0.0-prerelease.21462.2
…ild 20210912.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.2-alpha.0.21460.1 -> To Version 1.0.2-alpha.0.21462.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/runtime [main] Update dependencies from dotnet/runtime dnceng/internal/dotnet-optimization dotnet/hotreload-utils Sep 13, 2021
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dnceng/internal/dotnet-optimization dotnet/hotreload-utils [main] Update dependencies from dotnet/runtime dotnet/hotreload-utils dnceng/internal/dotnet-optimization Sep 14, 2021
…913.4

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 7.0.0-beta.21459.5 -> To Version 7.0.0-beta.21463.4
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/hotreload-utils dnceng/internal/dotnet-optimization [main] Update dependencies from dotnet/runtime dotnet/hotreload-utils dnceng/internal/dotnet-optimization dotnet/arcade Sep 14, 2021
@premun
Copy link
Member

premun commented Sep 15, 2021

@josteink do you know how to resolve this conflict? I saw you were making the changes there

@josteink
Copy link
Member

To me it almost looks like a complete syntactical rewrite with (among other things) [ ] replaced with [[ ]] and exports only done at the end.

I believe due to the excessive amount of changes git fails to merge it despite there being no direct “logical”/fundamental conflict in the changes.

How about you force a merge locally, resolve by choosing your branch, and then just “replay” my changes manually on top of yours?

@premun
Copy link
Member

premun commented Sep 15, 2021

I don't understand this script at all, maybe @jkoritzinsky or @am11 can help here? They authored the clashing change in Arcade

@josteink
Copy link
Member

Also, technically speaking, I was only reverting changes incorrectly being made earlier by another "Update dependencies" PR:

#58314

Conflicts:
	eng/Version.Details.xml
	eng/Versions.props
@premun
Copy link
Member

premun commented Sep 20, 2021

@josteink the way it works is that the eng/common folder from https://github.com/dotnet/arcade is always pushed to all of the repos that are dependent on https://github.com/dotnet/arcade. So making changes in the eng/common in the runtime repo will always result in conflicts or the changes will be overridden.

I do not understand this script or its purpose so it's quite hard for me to "replay" your changes (and I cannot simply apply the commit since there is a conflict) but it seems @jkoritzinsky and @am11 were making changes in dotnet/arcade so they might know how to best resolve this?

So far I have just put here their version of the script and we will see how the build goes.

@premun premun changed the title [main] Update dependencies from dotnet/runtime dotnet/hotreload-utils dnceng/internal/dotnet-optimization dotnet/arcade [main] Update dependencies from 4 repositories Sep 20, 2021
@premun premun merged commit d498440 into main Sep 20, 2021
@premun premun deleted the darc-main-38a2cfd6-0eb9-4324-b73e-94a0cfc64b31 branch September 20, 2021 15:07
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants