Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for DI's site call factory cache #59164

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

allantargino
Copy link
Contributor

failing test for issue #57333

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 15, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Extensions-DependencyInjection and removed community-contribution Indicates that the PR has been added by a community member labels Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

failing test for issue #57333

Author: allantargino
Assignees: -
Labels:

area-Extensions-DependencyInjection

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one tiny correction to use public API.

@eerhardt eerhardt merged commit 82223e5 into dotnet:main Sep 16, 2021
@allantargino allantargino deleted the issue-57333 branch September 27, 2021 19:45
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants