-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gcc CI to use gcc-11 container #59202
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
e135661
to
3de8738
Compare
check_cxx_compiler_flag(-faligned-new COMPILER_SUPPORTS_F_ALIGNED_NEW) | ||
if (COMPILER_SUPPORTS_F_ALIGNED_NEW) | ||
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-faligned-new>) | ||
if (CMAKE_CXX_COMPILER_ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition was missed out previously, and was failing the libs.native
subset build with gcc (which we currently don't exercise in the CI and maybe we can; since it takes 30-60 seconds max)
3de8738
to
21756e6
Compare
gcc leg has picked up the newer version:
no compiler warnings. There is one preexisting assembler warning which remained, however:
I haven't looked too deep but I think it is not related to GSCookie, or it is benign. The compiled binaries do have all the exported symbols in correct segments which we typically find when compiled with clang (like the ones which SOS looks for). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
With gcc9 leg, we had 2500+ warnings in JIT due to a bit field width issue: #33541.
Now that we have a dedicated gcc container, it is easier to upgrade gcc toolchain independent from llvm toolchain.
This PR uses the latest gcc 11 prereq image. The bitfield width warnings have been fixed in this version, therefore I have enabled Werror in the JIT for gcc version >= 11.
Fixes #33541