Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ConvertTo_String tests in System.Drawing.Common.Tests for null values #59367

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Updated ConvertTo_String tests in System.Drawing.Common.Tests for null values #59367

merged 1 commit into from
Sep 30, 2021

Conversation

AlexRadch
Copy link
Contributor

I updated ConvertTo_String tests in System.Drawing.Common.Tests for null values to do not fail with non-English UI.

Fix #59333 issue.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2021
@ghost
Copy link

ghost commented Sep 20, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

I updated ConvertTo_String tests in System.Drawing.Common.Tests for null values to do not fail with non-English UI.

Fix #59333 issue.

Author: AlexRadch
Assignees: -
Labels:

area-System.ComponentModel

Milestone: -

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is green.

@maryamariyan maryamariyan merged commit 5e8ba34 into dotnet:main Sep 30, 2021
@AlexRadch AlexRadch deleted the DrawingCommonTests_ConvertTo_String branch October 1, 2021 02:25
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.ComponentModel community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconConverterTest.TestConvertTo fail on net48 on non-English Windows
3 participants