Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume PosixSignal in Hosting.Systemd's SystemdLifetime #59880

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Consume PosixSignal in Hosting.Systemd's SystemdLifetime #59880

merged 4 commits into from
Nov 1, 2021

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 1, 2021

Fix #56058

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Oct 1, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #56058

Author: eerhardt
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Hosting
Milestone: -

@eerhardt
Copy link
Member Author

Thanks for all the feedback so far.

I believe this is ready for another review.

This was referenced Oct 22, 2021
Closed
Closed
Open
@eerhardt
Copy link
Member Author

CI failures are #60731

@tmds @stephentoub @maryamariyan - any more thoughts here?

tmds
tmds approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@tmds tmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@eerhardt
Merge branch 'main' into Fix56058
b34a944
@eerhardt
Fix TFMs to correctly include NetCoreApp
e48b6cf 
Also fixing duplicate entries in the .sln file, since it doesn't load correctly.
@eerhardt
Copy link
Member Author

FYI @ViktorHofer - this is the change I mentioned to you offline, if you want to take a look at the project changes. I think I got them right, but it would be great to confirm.

ViktorHofer
ViktorHofer approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The msbuild project file changes look right.

@eerhardt eerhardt mentioned this pull request Oct 28, 2021
Closed
49 tasks
@eerhardt eerhardt merged commit 759057f into dotnet:main Nov 1, 2021
@eerhardt eerhardt deleted the Fix56058 branch November 1, 2021 17:28
@ghost ghost locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@tmds tmds tmds approved these changes

@maryamariyan maryamariyan maryamariyan approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-Extensions-Hosting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consume PosixSignal in Microsoft.Extensions.Hosting.Systemd's SystemdLifetime
5 participants
@eerhardt @tmds @stephentoub @maryamariyan @ViktorHofer