Implement GT_AND_NOT for ARM/ARM64
#59881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis is a simple implementation of the operator, targeting AArch, but with a structure explicit in its intent to expand this optimization XArch as well, in the future. Diffs:
|
SingleAccretion
force-pushed
the
AArch-CodeGen-Opts
branch
2 times, most recently
from
a35e127
to
d90a59e
Compare
|
@dotnet/jit-contrib, @tannergooding |
|
Some conflicts need to be fixed. Edit: fixed. |
SingleAccretion
force-pushed
the
AArch-CodeGen-Opts
branch
from
d90a59e
to
bc94fa5
Compare
|
@echesakov can you PTAL? |
I will take a look. |
echesakov
reviewed
Oct 22, 2021
They were a leftover from some previous work.
echesakov
approved these changes
Nov 6, 2021
|
It looks that a similar optimization can be done for |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple implementation of the operator, targeting AArch, but with a structure explicit in its intent to expand this optimization to XArch as well, in the future.
Diffs:
win-arm64,linux-arm.