Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flaky ReadAllBytes_NonSeekableFileStream_InWindows #60471

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

adamsitnik
Copy link
Member

tries to fix #60427

I can't repro it locally, so I will just try here..

@adamsitnik adamsitnik added this to the 7.0.0 milestone Oct 15, 2021
@ghost
Copy link

ghost commented Oct 15, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

tries to fix #60427

I can't repro it locally, so I will just try here..

Author: adamsitnik
Assignees: -
Labels:

area-System.IO

Milestone: 7.0.0

@ericstj
Copy link
Member

ericstj commented Oct 15, 2021

I can't repro it locally, so I will just try here..

Another option would be to ActiveIssue this test while we work out a fix.

Also, we probably have examples of patterns that "work in CI" for testing using multiple threads and pipes. Those might be a place to look for a pattern that works here.

@adamsitnik
Copy link
Member Author

Another option would be to ActiveIssue this test while we work out a fix.

Good point, let's disable it now and unblock others while I'll try to come up with a better fix.

Also, we probably have examples of patterns that "work in CI" for testing using multiple threads and pipes. Those might be a place to look for a pattern that works here.

Yes, but in all these places we create FileStream from path, then call the connect method and perform some work. Here we don't have this possibility as the public method that we test accepts a string and does not allow us to control what happens right after opening the file.

@adamsitnik adamsitnik requested a review from ericstj October 15, 2021 16:53
@adamsitnik adamsitnik changed the title fix ReadAllBytes_NonSeekableFileStream_InWindows test disable flaky ReadAllBytes_NonSeekableFileStream_InWindows Oct 15, 2021
@adamsitnik
Copy link
Member Author

@ericstj @carlossanlop @jozkee I will be starting my weekend soon, could you please merge this PR when it gets green?

@adamsitnik adamsitnik added the disabled-test The test is disabled in source code against the issue label Oct 15, 2021
@ericstj
Copy link
Member

ericstj commented Oct 15, 2021

Failure is #59736

Merging to fix CI

@ericstj ericstj merged commit 53590db into dotnet:main Oct 15, 2021
@adamsitnik adamsitnik deleted the issue60427 branch October 16, 2021 20:14
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.IO.Tests.File_ReadWriteAllBytes.ReadAllBytes_NonSeekableFileStream_InWindows failed
2 participants