Fix for Ctor_Brush_Width test on Non-English Windows #60502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsFix for #60480 issue
|
safern
reviewed
Oct 16, 2021
| yield return new object[] { new SolidBrush(Color.Red), 0, PenType.SolidColor }; | ||
| yield return new object[] { new SolidBrush(Color.Red), -1, PenType.SolidColor }; | ||
| // Issue on Non-English Windows with brush width < 1. See https://github.com/dotnet/runtime/issues/60480 | ||
| if (Environment.OSVersion.Platform != PlatformID.Win32NT || CultureInfo.InstalledUICulture.TwoLetterISOLanguageName == "en") |
There was a problem hiding this comment.
Nit: we usually use, !PlatformDetection.IsWindows to detect if running or not on windows on our tests.
There was a problem hiding this comment.
Should I change Windows OS checking to OperatingSystem.IsWindows() or not?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #60480 issue