make System.Security.Cryptography.X509Certificates compliant with interop guidelines - part 2 #61010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsFixes partially issue #51564 This PR makes the following calls compliant with Interop gudielines :
|
pedrobsaila
changed the title
bartonjs
reviewed
Oct 29, 2021
| @@ -10,6 +10,7 @@ | |||
| using System.Security.Cryptography.X509Certificates; | |||
|
|
|||
| using Internal.Cryptography.Pal.Native; | |||
| using static Interop.Crypt32; | |||
There was a problem hiding this comment.
Please don't add any using statics in this PR. It's nice to clearly see when we're moving over toward interop calls.
bartonjs
approved these changes
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially issue #51564
(this issue is still under progress, more PRs are to come)
This PR makes the following calls compliant with Interop gudielines :