Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fix incorrect CCW decoding in GetObjectForCCW #61341

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

tommcdon
Copy link
Member

@tommcdon tommcdon commented Nov 9, 2021

Backport of #61193 to release/6.0

/cc @davmason @mikem8361 @hoyosjs

Customer Impact

This issue blocks debugger API's for correctly identifying .NET 5.0+ COM wrappers.

Testing

Validated an end-to-end scenario using COM wrappers

Risk

Low. We are falling back to the old COM decoding logic if the new COM wrapper API code check does not succeed.

* Fix incorrect CCW decoding in GetObjectForCCW

* Fix linux/mac build
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@jeffschwMSFT jeffschwMSFT changed the title Fix incorrect CCW decoding in GetObjectForCCW [release/6.0] Fix incorrect CCW decoding in GetObjectForCCW Nov 9, 2021
@jeffschwMSFT jeffschwMSFT added area-Diagnostics-coreclr Servicing-consider Issue for next servicing release review labels Nov 9, 2021
@ghost
Copy link

ghost commented Nov 9, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #61193 to release/6.0

/cc @davmason @mikem8361 @hoyosjs

Customer Impact

This issue blocks debugger API's for correctly identifying .NET 5.0+ COM wrappers.

Testing

Validated an end-to-end scenario using COM wrappers

Risk

Low. We are falling back to the old COM decoding logic if the new COM wrapper API code check does not succeed.

Author: tommcdon
Assignees: -
Labels:

Servicing-consider, area-Diagnostics-coreclr

Milestone: -

@jeffschwMSFT jeffschwMSFT added this to the 6.0.x milestone Nov 9, 2021
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's consider this for 6.0.x

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 9, 2021
@leecow leecow modified the milestones: 6.0.x, 6.0.1 Nov 9, 2021
@Anipik Anipik merged commit 13709ae into dotnet:release/6.0 Nov 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants