Use GeneratedDllImport in System.Data.Odbc, System.IO.Ports, System.ServiceProcess.ServiceController #61741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
jkoritzinsky
approved these changes
Nov 17, 2021
stephentoub
reviewed
Nov 17, 2021
| [DllImport(Interop.Libraries.Odbc32)] | ||
| internal static extern /*SQLRETURN*/ODBC32.RetCode SQLAllocHandle( | ||
| [GeneratedDllImport(Interop.Libraries.Odbc32)] | ||
| internal static partial ODBC32.RetCode SQLAllocHandle( |
There was a problem hiding this comment.
I wonder if we should rename RetCode to SQLRETURN?
stephentoub
reviewed
Nov 17, 2021
| @@ -8,8 +8,8 @@ internal static partial class Interop | |||
| { | |||
| internal static partial class Kernel32 | |||
| { | |||
| [DllImport(Libraries.Kernel32, SetLastError = true, CharSet = CharSet.Auto)] | |||
| internal static extern bool GetCommProperties( | |||
| [GeneratedDllImport(Libraries.Kernel32, CharSet = CharSet.Unicode, SetLastError = true)] | |||
There was a problem hiding this comment.
Why is Unicode needed here... is that because COMMPROP contains a char?
There was a problem hiding this comment.
Should not be needed - removed.
stephentoub
approved these changes
Nov 17, 2021
This was referenced Nov 29, 2021
Merged
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AaronRobinsonMSFT @jkoritzinsky