Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few special cases of projects with command line arguments #61758

Merged
merged 5 commits into from
Nov 22, 2021
Merged

Fix a few special cases of projects with command line arguments #61758

merged 5 commits into from
Nov 22, 2021

Commits on Nov 21, 2021

  1. Remove CLRTestExecutionArguments from OOMException01 

    Test entrypoint is parameterless and so it ignores the argument
    @trylek
    trylek committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    04fdb7f View commit details
    Browse the repository at this point in the history

  2. The test entrypoint for 347011 is parameterless so the property is ig… 

    …nored
    @trylek
    trylek committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    cfa4e8b View commit details
    Browse the repository at this point in the history

  3. Remove project-driven command line arguments from the polyrec test 

    The test just passes a pair of integers that are used as internal
parameters for the test. Refactor the test so that the entrypoint
accepts the parameters as arguments and call it once from Main
the way we used to do based on the CLRTestExecutionArguments.

Thanks

Tomas
    @trylek
    trylek committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    b16344c View commit details
    Browse the repository at this point in the history

  4. Fix the polyrec.cs test based on PR feedback 

    Based on PR feedback and Jeremy's check-in of the Roslyn
generator test logic I can now fully update the test so that it
no longer contains the Main method and it just implements
the [Fact]-marked test entrypoint.

Thanks

Tomas
    @trylek
    trylek committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    1a558ef View commit details
    Browse the repository at this point in the history

  5. Remove the exe test output type from the polyrec.csproj project

    @trylek
    trylek committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    cf4ce39 View commit details
    Browse the repository at this point in the history