Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reflection or a compile-time only shim assembly to reference unexposed corelib types. #61802

Merged
merged 8 commits into from
Nov 20, 2021
Merged

Use reflection or a compile-time only shim assembly to reference unexposed corelib types. #61802

merged 8 commits into from
Nov 20, 2021

Commits on Nov 18, 2021

  1. Use reflection or a compile-time only shim assembly to reference unex… 

    …posed corelib types.

Use reflection for the hosting tests as they'll be around indefinitely.

Use the ref-assembly trick for ICastable testing since ICastable testing would require Ref-emit which makes the test significantly less readable and since ICastable will be going away within the .NET 7 timeframe. Supercedes dotnet#61754
    @jkoritzinsky
    jkoritzinsky committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0cf62d2 View commit details
    Browse the repository at this point in the history

  2. Disable on Mono

    @jkoritzinsky
    jkoritzinsky committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    abb93b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Use function pointers in the Activator tests to simplify. Add back so… 

    …me of that complexity to handle IClassFactory (since type equivalence in corelib breaks things really badly)
    @jkoritzinsky
    jkoritzinsky committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    7e49f04 View commit details
    Browse the repository at this point in the history

  2. Fix accessibility in the PNSE implementation.

    @jkoritzinsky
    jkoritzinsky committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    fcee76f View commit details
    Browse the repository at this point in the history

  3. Don't need CLS Compliance checks on private members

    @jkoritzinsky
    jkoritzinsky committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    c842ecf View commit details
    Browse the repository at this point in the history

  4. Fix test compilation.

    @jkoritzinsky
    jkoritzinsky committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    61c106a View commit details
    Browse the repository at this point in the history

  5. Fix the Activator tests based on local testing

    @jkoritzinsky
    jkoritzinsky committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    392291e View commit details
    Browse the repository at this point in the history

  6. Update src/tests/Interop/COM/Activator/Activator.csproj 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @jkoritzinsky @AaronRobinsonMSFT
    jkoritzinsky and AaronRobinsonMSFT authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    182a895 View commit details
    Browse the repository at this point in the history