Fix superpmi.exe handling of exclusion lists #62349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superpmi.exe has the concept of an exclusion list file which is automatically read and processed when reading a .mch file. (I'm not sure if anyone actually uses it.) So, when opening a `t.mch` file, it looks for an adjacent `t.mch.exc` and then `t.exc` file. There was a bug where it would also look for a `t` file (the comments say it takes t.exc.mch and looks for t.exc, but it didn't check for that). In my case when I was testing, I actually had a `t` directory (not file), which it found, but then emitted an error trying to load. So, two fixes: 1. For `t.mch`, don't look for `t`. 2. Check all cases for being a directory, and fail if any name is a directory.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue Detailssuperpmi.exe has the concept of an exclusion list file which is automatically read There was a bug where it would also look for a So, two fixes:
|
|
@dotnet/jit-contrib PTAL |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superpmi.exe has the concept of an exclusion list file which is automatically read
and processed when reading a .mch file. (I'm not sure if anyone actually uses it.)
So, when opening a
t.mchfile, it looks for an adjacentt.mch.excand thent.excfile.
There was a bug where it would also look for a
tfile (the comments say it takes t.exc.mchand looks for t.exc, but it didn't check for that). In my case when I was testing, I actually
had a
tdirectory (not file), which it found, but then emitted an error trying to load.So, two fixes:
t.mch, don't look fort.