Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Mono runtime tests on PRs #62437

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

akoeplinger
Copy link
Member

@ghost
Copy link

ghost commented Dec 6, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

/cc @steveisok

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
@akoeplinger akoeplinger changed the title Reenable Mono llvmaot runtime tests on PRs Reenable Mono runtime tests on PRs Dec 7, 2021
@akoeplinger
Copy link
Member Author

Updated based on feedback.

@lambdageek lambdageek requested a review from steveisok December 7, 2021 17:43
@akoeplinger
Copy link
Member Author

@lambdageek there's an error on the Mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release job, is that one known?

  aot-compile: compiling /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll; MONO_PATH: /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root:/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root
  Failed to load method 0x6000034 from '/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll' due to Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies..
  Run with MONO_LOG_LEVEL=debug for more information.
  AOT of image /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll failed.
  Mono Ahead of Time compiler - compiling assembly /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll

@lambdageek
Copy link
Member

lambdageek commented Dec 7, 2021

Update: I'm wrong this is known.

@lambdageek there's an error on the Mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release job, is that one known?

  aot-compile: compiling /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll; MONO_PATH: /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root:/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root
  Failed to load method 0x6000034 from '/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll' due to Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies..
  Run with MONO_LOG_LEVEL=debug for more information.
  AOT of image /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll failed.
  Mono Ahead of Time compiler - compiling assembly /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/Microsoft.Interop.DllImportGenerator.dll

I don't think I've seen this before. I don't think that DllImportGenerator.dll should be copied to Core_Root (or at least it shouldn't be AOTd once it's in Core_Root) - I think it's a C# source generator.

@jkotas
Copy link
Member

jkotas commented Dec 7, 2021

#62372 ?

@steveisok
Copy link
Member

#62372 ?

Should we skip anything before enabling?

@akoeplinger akoeplinger merged commit 18944ff into dotnet:main Dec 9, 2021
@akoeplinger akoeplinger deleted the reenable-mono-runtime-tests branch December 9, 2021 20:34
@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants