-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move a few vendor libraries to src/native/external #62673
Conversation
cc @jkotas
The format is: src/native/external/{libname}/
src/native/external/{libname}-version.txt
src/native/external/{libname}.cmake # exception being rapidjson which is header-only lib with no build configs @janvorli, I was thinking about moving libunwind here as well and refactoring our configurations in a |
3b269fc
to
31c4d33
Compare
Red diffs are because one copy (out of three) of zlib is deleted from the repo. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsMoved:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
Except for the ones in vendor directory: ```sh # git remote add dotnet https://github.com/dotnet/runtime && git pull --rebase dotnet main if uname 2>/dev/null | grep -q Darwin; then space=" " fi git show --name-only --pretty="" HEAD...dotnet/main \ ':!*external/brotli/*' ':!*external/rapidjson/*' ':!*external/zlib/*' ':!*external/zlib-intel/*' | xargs -I{} sh -c "test -f {} && sed -i$space'' 's/[[:space:]]*$//' {}" ```
Moved: