-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Collapse mono runtime tests into single builds using global-build-job template #62863
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine. This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast. It also lets use remove the coreclr dependency on the effected mono lanes. Contributes to: #45521 Draft while I iron out issues in CI.
|
eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
Outdated
Show resolved
Hide resolved
Azure Pipelines failed to run 1 pipeline(s). |
1 similar comment
Azure Pipelines failed to run 1 pipeline(s). |
/azp run runtime-manual |
e71cf46
to
8d7ce1d
Compare
9df2172
to
0afa6b9
Compare
Tagging subscribers to this area: @directhex Issue DetailsThis PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine. This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast. It also lets use remove the coreclr dependency on the effected mono lanes. Contributes to: #45521 Draft while I iron out issues in CI. Also only moving hte osx_x64 lane for testing purposes.
|
3672749
to
5d1b06a
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
149aee5
to
27573d9
Compare
eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a few nits, thank you!
Outdated change requests on old draft
Failures seem spurious. |
I am reviving this PR from a while ago.
This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.
This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.
It also lets use remove the coreclr dependency on the effected mono lanes.
There were a few tests that didn't run successfully with out the coreclr build for different reasons; I have excluded them in issues.targets for now and will investigate them individually as a follow up item.
mono-windows is still using the old path while I investigate some errors in the build.cmd script.
Contributes to: #45521
This PR only changes the ones in the runtime pipeline. Follow up PRs will change runtime-staging.