Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Collapse mono runtime tests into single builds using global-build-job template #62863

Merged
merged 7 commits into from
Nov 19, 2022

Conversation

naricc
Copy link
Contributor

@naricc naricc commented Dec 15, 2021

I am reviving this PR from a while ago.

This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.

This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.

It also lets use remove the coreclr dependency on the effected mono lanes.

There were a few tests that didn't run successfully with out the coreclr build for different reasons; I have excluded them in issues.targets for now and will investigate them individually as a follow up item.

mono-windows is still using the old path while I investigate some errors in the build.cmd script.

Contributes to: #45521

This PR only changes the ones in the runtime pipeline. Follow up PRs will change runtime-staging.

@ghost
Copy link

ghost commented Dec 15, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.

This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.

It also lets use remove the coreclr dependency on the effected mono lanes.

Contributes to: #45521

Draft while I iron out issues in CI.

Author: naricc
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@naricc naricc closed this Dec 20, 2021
@naricc naricc reopened this Dec 20, 2021
@naricc
Copy link
Contributor Author

naricc commented Jan 4, 2022

/azp run runtime-manual

@naricc naricc force-pushed the naricc/runtime-global-run branch from e71cf46 to 8d7ce1d Compare January 10, 2022 21:05
@naricc naricc requested a review from imhameed January 12, 2022 20:18
@naricc naricc changed the title [Draft][Mono][Test] Collapse mono runtime tests into single builds using global-build-job template [Mono][Test] Collapse mono runtime tests into single builds using global-build-job template Jan 21, 2022
@naricc naricc marked this pull request as ready for review January 21, 2022 16:54
@naricc naricc force-pushed the naricc/runtime-global-run branch 2 times, most recently from 9df2172 to 0afa6b9 Compare January 26, 2022 00:16
@ghost
Copy link

ghost commented Feb 28, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.

This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.

It also lets use remove the coreclr dependency on the effected mono lanes.

Contributes to: #45521

Draft while I iron out issues in CI. Also only moving hte osx_x64 lane for testing purposes.

Author: naricc
Assignees: naricc
Labels:

area-Infrastructure-mono

Milestone: -

@naricc naricc force-pushed the naricc/runtime-global-run branch from 3672749 to 5d1b06a Compare May 6, 2022 18:46
@SamMonoRT
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@naricc naricc force-pushed the naricc/runtime-global-run branch from 149aee5 to 27573d9 Compare July 15, 2022 17:05
@naricc naricc requested a review from radical as a code owner July 15, 2022 17:05
eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 15, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 18, 2022
@dotnet dotnet deleted a comment from Universal2313 Nov 18, 2022
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a few nits, thank you!

@naricc naricc dismissed radical’s stale review November 18, 2022 20:33

Outdated change requests on old draft

@naricc
Copy link
Contributor Author

naricc commented Nov 19, 2022

Failures seem spurious.

@naricc naricc merged commit fe2e4e4 into dotnet:main Nov 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants