[LoongArch64] coreclr-vm directory #62885

shushanhf · 2021-12-16T03:47:52Z

Part6-2: Add the coreclr-vm directory for LoongArch64.

update from runtime.

Co-authored-by: Loongson's .NET-teams

dnfadmin · 2021-12-16T03:48:05Z

All CLA requirements met.

src/coreclr/vm/syncblk.cpp

kant2002

Left some comments.

src/coreclr/vm/ceeload.h

src/coreclr/vm/class.cpp

src/coreclr/vm/comdelegate.cpp

src/coreclr/vm/interpreter.cpp

src/coreclr/vm/callhelpers.cpp

jkotas · 2021-12-18T13:57:21Z

src/coreclr/vm/argdestination.h

+    void CopyStructToRegisters(void *src, int fieldBytes)
+    {
+        _ASSERTE(IsStructPassedInRegs());
+        _ASSERTE(m_argLocDescForStructInRegs->m_cFloatReg == 1);


Where is the case of struct passed in two floating registers handled?

Where is the case of struct passed in two floating registers handled?

A struct containing just one floating-point real is passed as though it were a standalone floating-point real.
It's related with the ABI, similar with the PR #62893 ,
#62893 (comment)

This case is also the same with the RISC-V: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-cc.adoc

kant2002

Some comments about compilation issues.

src/coreclr/vm/exceptionhandling.cpp

src/coreclr/vm/jitinterface.cpp

moved inc/corinfo.h from #6288.

…nkGenerator/gen.sh` and merge the patch from #62893.

amend the `ToolBox/superpmi/superpmi-shared/agnostic.h`

src/coreclr/vm/methodtable.cpp

after merged `MethodTable::GetLoongArch64PassStructInRegisterFlags()` and `CEEInfo::getLoongArch64PassStructInRegisterFlags()`

BruceForstall · 2022-03-21T17:17:27Z

@shushanhf Now that #65738 has merged, this needs to be updated.

shushanhf · 2022-03-22T01:01:39Z

@shushanhf Now that #65738 has merged, this needs to be updated.

OK, Thanks

For porting #65738 to LoongArch64.

BruceForstall · 2022-03-22T17:04:28Z

@jkotas @janvorli Time for another (final?) code review here?

src/coreclr/vm/loongarch64/thunktemplates.S

when running hello-world within debug-mode after refacting.

shushanhf · 2022-04-08T04:36:38Z

Now I had tested the hello-world passed both the release and debug mode based on the latest main-LoongArch64.

BruceForstall · 2022-04-08T18:09:35Z

@mangod9 @janvorli @jkotas Is there anything left here to review? (fyi, I just merged the LoongArch64 JIT PR)

shushanhf · 2022-04-13T18:36:38Z

@mangod9 @janvorli @jkotas
Could you please give me some advices further?

shushanhf · 2022-04-20T22:27:28Z

Hi, @mangod9 @janvorli @jkotas

What should I do for this PR next？
Could you please give me some advices ?

mangod9 · 2022-04-20T22:29:06Z

Hi @shushanhf, sorry for delayed response. We plan to review this again this week and will merge with a green CI. Thanks

janvorli

LGTM, thank you!

mangod9 · 2022-04-21T03:51:36Z

Some JIT HW Intrinsics tests are failing -- I will submit a rerun.
cc @BruceForstall in case these have been seen before: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-62885-merge-13bbab73369a44af9a/JIT.HardwareIntrinsics/1/console.c2df8b25.log?sv=2019-07-07&se=2022-04-28T05%3A53%3A25Z&sr=c&sp=rl&sig=B24gI9K1nVgOTBqIiWnGKoSByMPjTbvq0VZSpMHTCbc%3D

mangod9 · 2022-04-21T16:55:14Z

Looks to have passed on rerun. So will merge it now.

BruceForstall · 2022-04-21T17:41:47Z

@shushanhf Thanks for your patience and response to code review feedback. And congratulations on getting this merged!

* [LoongArch64] add coreclr-inc,gc, ToolBox directory. (#59561) Co-authored-by: Loongson's .NET-teams * [LoongArch64] move inc/switches.h to #62889. * [LoongArch64] move some configure files from #62889. * [LoongArch64] revert the modify when moved from #62889. * [LoongArch64] moved the inc/stdmacros.h to #62885. * [LoongArch64] moved inc/corinfo.h to #62885. * [LoongArch64] modify the related files for compiling error. * [LoongArch64] revert the `src/coreclr/gcinfo/CMakeLists.txt` to original. * [LoongArch64] delete unused files on windows. * [LoongArch64] add define IMAGE_FILE_MACHINE_LOONGARCH64. * [LoongArch64] workround the compiling error for IMAGE_FILE_MACHINE_LOONGARCH64 on windows. * [LoongArch64] workround the compiling error for SPMI_TARGET_ARCHITECTURE_LOONGARCH64 on windows. * [LoongArch64] delete the memcpy for LoongArch64 and revert workround patches. * [LoongArch64] exclude the gc, ToolBox and config files from this PR. * [LoongArch64] amend code for compiling error on LoongArch64-machine. * [LoongArch64] update the version of the `LICENSE description`. * [LoongArch64] amend the code about debug. * [LoongArch64] temp submit for fixing the windows compiling error. * [LoongArch64] amend some LA's implements for CR. Co-authored-by: qiaopengcheng <qiaopengcheng-hf@loongson.cn>

shushanhf and others added 9 commits April 27, 2021 16:32

Merge pull request #1 from dotnet/main

47d106f

update from runtime.

Merge branch 'dotnet:main' into master

411b59e

Merge branch 'dotnet:main' into master

7eed4eb

Merge branch 'dotnet:main' into master

0d7c9e4

Merge branch 'dotnet:main' into master

2c534c5

Merge branch 'dotnet:main' into master

6e14d76

Merge branch 'dotnet:main' into master

359875d

Merge branch 'dotnet:main' into main

192b095

Part6-2: -add the coreclr-vm directory for LoongArch64. (#59561)

8a9d654

Co-authored-by: Loongson's .NET-teams

ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 16, 2021

dotnet-issue-labeler bot added the area-VM-coreclr label Dec 16, 2021

shushanhf mentioned this pull request Dec 16, 2021

[LoongArch64] coreclr-jit directory #62843

Merged

jkotas changed the title ~~Part6-2: Add the coreclr-vm directory for LoongArch64.~~ [LoongArch64] coreclr-vm directory Dec 16, 2021

jkotas reviewed Dec 16, 2021

View reviewed changes

src/coreclr/vm/syncblk.cpp Outdated Show resolved Hide resolved

[LoongArch64] revert the syncblk.cpp.

4606899

kant2002 reviewed Dec 17, 2021

View reviewed changes

shushanhf commented Dec 18, 2021

View reviewed changes

src/coreclr/vm/interpreter.cpp Show resolved Hide resolved

[LoongArch64] delete some unused codes.

e62a6cd

kant2002 mentioned this pull request Dec 18, 2021

[LoongArch64] add all the coreclr-build-config files #62889

Merged

[LoongArch64] add vm/CMakeLists.txt from #62889.

cdb7606

jkotas reviewed Dec 18, 2021

View reviewed changes

src/coreclr/vm/callhelpers.cpp Outdated Show resolved Hide resolved

jkotas reviewed Dec 18, 2021

View reviewed changes

kant2002 reviewed Dec 18, 2021

View reviewed changes

src/coreclr/vm/exceptionhandling.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/jitinterface.cpp Outdated Show resolved Hide resolved

[LoongArch64] add related files from #62886 and #62893.

ad3b666

shushanhf requested a review from MichalStrehovsky as a code owner December 20, 2021 01:37

qiaopengcheng and others added 3 commits December 20, 2021 10:32

[LoongArch64] moved vm/jitinterface.cpp from #62893.

7d03307

moved inc/corinfo.h from #6288.

[LoongArch64] run the file `src/coreclr/tools/Common/JitInterface/Thu…

f6ec562

…nkGenerator/gen.sh` and merge the patch from #62893.

[LoongArch64] revert vm/ceeload.h.

277de6f

amend the `ToolBox/superpmi/superpmi-shared/agnostic.h`

shushanhf mentioned this pull request Dec 20, 2021

[LoongArch64] JIT/EE interface for getting ABI-info #62893

Merged

jkotas reviewed Mar 3, 2022

View reviewed changes

src/coreclr/vm/methodtable.cpp Outdated Show resolved Hide resolved

jkotas reviewed Mar 7, 2022

View reviewed changes

src/coreclr/vm/methodtable.cpp Outdated Show resolved Hide resolved

jkotas reviewed Mar 7, 2022

View reviewed changes

src/coreclr/vm/methodtable.cpp Outdated Show resolved Hide resolved

jkotas reviewed Mar 7, 2022

View reviewed changes

src/coreclr/vm/methodtable.cpp Outdated Show resolved Hide resolved

[LoongArch64] Amend the LoongArch64's ABI

6566991

after merged `MethodTable::GetLoongArch64PassStructInRegisterFlags()` and `CEEInfo::getLoongArch64PassStructInRegisterFlags()`

shushanhf requested review from jkotas, janvorli and mangod9 March 11, 2022 02:08

Merge branch 'main' into main_loongarch64_2

9f39e13

For porting #65738 to LoongArch64.

janvorli reviewed Apr 4, 2022

View reviewed changes

src/coreclr/vm/loongarch64/thunktemplates.S Show resolved Hide resolved

[LoongArch64] Fix the assert error

d6c7080

when running hello-world within debug-mode after refacting.

shushanhf requested a review from janvorli April 13, 2022 02:46

janvorli approved these changes Apr 20, 2022

View reviewed changes

mangod9 merged commit febeba3 into dotnet:main Apr 21, 2022

shushanhf deleted the main_loongarch64_2 branch May 11, 2022 01:12

ghost locked as resolved and limited conversation to collaborators Jun 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LoongArch64] coreclr-vm directory #62885

[LoongArch64] coreclr-vm directory #62885

shushanhf commented Dec 16, 2021

dnfadmin commented Dec 16, 2021 •

edited

Loading

kant2002 left a comment

jkotas Dec 18, 2021 •

edited

Loading

shushanhf Dec 20, 2021 •

edited

Loading

kant2002 left a comment

BruceForstall commented Mar 21, 2022

shushanhf commented Mar 22, 2022

BruceForstall commented Mar 22, 2022

shushanhf commented Apr 8, 2022 •

edited

Loading

BruceForstall commented Apr 8, 2022

shushanhf commented Apr 13, 2022

shushanhf commented Apr 20, 2022 •

edited

Loading

mangod9 commented Apr 20, 2022

janvorli left a comment

mangod9 commented Apr 21, 2022

mangod9 commented Apr 21, 2022

BruceForstall commented Apr 21, 2022

[LoongArch64] coreclr-vm directory #62885

[LoongArch64] coreclr-vm directory #62885

Conversation

shushanhf commented Dec 16, 2021

dnfadmin commented Dec 16, 2021 • edited Loading

kant2002 left a comment

Choose a reason for hiding this comment

jkotas Dec 18, 2021 • edited Loading

Choose a reason for hiding this comment

shushanhf Dec 20, 2021 • edited Loading

Choose a reason for hiding this comment

kant2002 left a comment

Choose a reason for hiding this comment

BruceForstall commented Mar 21, 2022

shushanhf commented Mar 22, 2022

BruceForstall commented Mar 22, 2022

shushanhf commented Apr 8, 2022 • edited Loading

BruceForstall commented Apr 8, 2022

shushanhf commented Apr 13, 2022

shushanhf commented Apr 20, 2022 • edited Loading

mangod9 commented Apr 20, 2022

janvorli left a comment

Choose a reason for hiding this comment

mangod9 commented Apr 21, 2022

mangod9 commented Apr 21, 2022

BruceForstall commented Apr 21, 2022

dnfadmin commented Dec 16, 2021 •

edited

Loading

jkotas Dec 18, 2021 •

edited

Loading

shushanhf Dec 20, 2021 •

edited

Loading

shushanhf commented Apr 8, 2022 •

edited

Loading

shushanhf commented Apr 20, 2022 •

edited

Loading