Enable support for nint/nuint for Vector64/128/256<T> #63329
Conversation
ghost
assigned 
dotnet-issue-labeler
bot
added
area-CodeGen-coreclr
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis resolves #52017
|
|
The bulk of the change here is removing the |
| if ((baseJitType == CORINFO_TYPE_NATIVEINT) || (baseJitType == CORINFO_TYPE_NATIVEUINT)) | ||
| { | ||
| // We don't want to support the general purpose helpers for nint/nuint until after they go through API review. | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the JIT change. Just had to remove the if statement blocking the types.
| @@ -1053,6 +1125,7 @@ static Vector64<uint> SoftwareFallback(uint e0, uint e1) | |||
| /// <summary>Creates a new <see cref="Vector64{Byte}" /> instance with the first element initialized to the specified value and the remaining elements initialized to zero.</summary> | |||
| /// <param name="value">The value that element 0 will be initialized to.</param> | |||
| /// <returns>A new <see cref="Vector64{Byte}" /> instance with the first element initialized to <paramref name="value"/> and the remaining elements initialized to zero.</returns> | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
There was a problem hiding this comment.
I assume these additions were intentional?
There was a problem hiding this comment.
Yes, they already existed for Vector128/256 but were missed for Vector64 in a previous PR.
This resolves #52017