Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate #60154 #63357

Merged
merged 8 commits into from
Feb 3, 2022
Merged

Mitigate #60154 #63357

merged 8 commits into from
Feb 3, 2022

Conversation

echesakov
Copy link
Contributor

@echesakov echesakov commented Jan 4, 2022 •
edited
Loading

Mitigate #60154 by disabling intrinsics that throw NotSupportedPlatformException on the corresponding platforms

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 4, 2022
@ghost ghost assigned echesakov Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: echesakovMSFT
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@echesakov echesakov linked an issue Jan 4, 2022 that may be closed by this pull request
Test failure: JIT/HardwareIntrinsics/General/Vector256/Vector256_ro/Vector256_ro.sh Timed Out #60154
Closed
This was referenced Feb 1, 2022
Closed
Merged
sbomer
sbomer approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/tests/issues.targets Show resolved Hide resolved
tannergooding
tannergooding approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just calling out that the IsSupported == false scenario will be covered in the outerloop tests where we toggle the COMPlus_Enable...=0 switches

@echesakov
Copy link
Contributor Author

Looked at the Tests tab in Azure DevOps and it seems that the change does what was intended.

The failures with macOS Helix queues are irrelevant and fixed in #64565

@echesakov echesakov merged commit 0c3a6ee into dotnet:main Feb 3, 2022
@echesakov echesakov deleted the Runtime_60154 branch February 3, 2022 22:14
@tannergooding tannergooding mentioned this pull request Feb 7, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

@echesakov echesakov

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: JIT/HardwareIntrinsics/General/Vector256/Vector256_ro/Vector256_ro.sh Timed Out
3 participants
@echesakov @sbomer @tannergooding