Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate behavior of ProcessInfo command before and after suspension point #63382

Merged
merged 8 commits into from
Feb 3, 2022

Conversation

josalem
Copy link
Contributor

@josalem josalem commented Jan 5, 2022

Adds a test for the behavior of the commandline property on the ProcessInfo command before and after the diagnostics suspension point.

Before the suspension point, the PAL/Host populates the value to be the path to the host executable.

After the runtime is resumed and g_EEStarted==true, this value becomes the correct calculated value from the PAL.

This test validates this behavior and is intended for inclusion in #63356.

CC @tommcdon

@josalem josalem added test-enhancement Improvements of test source code area-Diagnostics-coreclr labels Jan 5, 2022
@josalem josalem added this to the 7.0.0 milestone Jan 5, 2022
@josalem josalem requested a review from a team January 5, 2022 01:31
@josalem josalem self-assigned this Jan 5, 2022
@ghost
Copy link

ghost commented Jan 5, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds a test for the behavior of the commandline property on the ProcessInfo command before and after the diagnostics suspension point.

Before the suspension point, the PAL/Host populates the value to be the path to the host executable.

After the runtime is resumed and g_EEStarted==true, this value becomes the correct calculated value from the PAL.

This test validates this behavior and is intended for inclusion in #63356.

CC @tommcdon

Author: josalem
Assignees: josalem
Labels:

test enhancement, area-Diagnostics-coreclr

Milestone: 7.0.0

@josalem
Copy link
Contributor Author

josalem commented Jan 5, 2022

macOS failures seem to be a timing issue since the test passes on my local macbook. I'll adjust the test.

@hoyosjs hoyosjs merged commit c99b3c7 into dotnet:main Feb 3, 2022
hoyosjs pushed a commit that referenced this pull request Feb 3, 2022
…point (#63382)

This only applies to CoreCLR Unix processes.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants