#51371 removed CaseInsensitivePlatforms and CaseSensitivePlatforms parameters #64440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsRefactored casesesintive test cases to use IsCaseSensitiveOS and IsCaseInsensitiveOS.
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mkhamoyan
requested review from
MaximLipnin,
steveisok,
directhex,
lateralusX,
akoeplinger,
simonrozsival and
mdh1418
akoeplinger
approved these changes
Jan 28, 2022
adamsitnik
reviewed
Jan 28, 2022
| @@ -224,8 +224,7 @@ public void WindowsWhiteSpaceAsPath_ReturnsFalse(string component) | |||
|
|
|||
| } | |||
|
|
|||
| [Fact] | |||
| [PlatformSpecific(CaseInsensitivePlatforms)] | |||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsCaseInsensitiveOS))] | |||
There was a problem hiding this comment.
just for my education: what is the benefit of doing that?
There was a problem hiding this comment.
As we had 2 ways to check "case sensitivity" having only one will make it it less confusing. And I kept boolean parameter because in some places only bool can be used.
danmoseley
approved these changes
Jan 28, 2022
|
If you put the issue ID in the description then it becomes hyperlinked. You can also put "Fixes ..." if the merge should close the issue. |
adamsitnik
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51371 Refactored casesesintive test cases to use IsCaseSensitiveOS and IsCaseInsensitiveOS.