Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable WasmTemplateTests on CI #64589

Merged
merged 16 commits into from
Feb 3, 2022
Merged

[wasm] Enable WasmTemplateTests on CI #64589

merged 16 commits into from
Feb 3, 2022

Conversation

radical
Copy link
Member

@radical radical commented Feb 1, 2022 •
edited
Loading

@ghost ghost assigned radical Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

cc @radekdoulik

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-libraries, area-Build-mono
Milestone: -

@radekdoulik radekdoulik marked this pull request as ready for review February 1, 2022 16:50
@radical radical requested a review from lewing February 2, 2022 02:32
@radical
Copy link
Member Author

radical commented Feb 2, 2022

@safern I've added eng/Version.Details.xml to the list of paths to trigger Wasm.Build.Tests, so we can catch issues introduced by arcade update PRs, like when getting an dotnet/emsdk update.

@lewing
Copy link
Member

lewing commented Feb 2, 2022

After this lands we can merge dotnet/emsdk#102

@lewing
Copy link
Member

lewing commented Feb 2, 2022

I've updated the missing helix lane to something that still exists, I have no idea if it is the best one but we have several prs blocked on the missing one

@radical
Copy link
Member Author

radical commented Feb 3, 2022

CoreCLR Pri0 Runtime Tests Run Linux arm checked is #60154

Others (unrelated) are due to missing helix queues:

  • CoreCLR Pri0 Runtime Tests Run OSX x64 checked
  • Libraries Test Run checked coreclr OSX x64 Debug
  • Mono minijit Pri0 Runtime Tests Run OSX x64 release
  • Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release

@radical radical merged commit ee5e6be into dotnet:main Feb 3, 2022
@radical radical deleted the enable-template-tests branch February 3, 2022 07:14
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@radekdoulik radekdoulik radekdoulik approved these changes

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @lewing @radekdoulik