Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about ignored checks to superpmi-asmdiffs and enterprise-linux pipelines #64685

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

premun
Copy link
Member

@premun premun commented Feb 2, 2022

Following pipelines are skipped for Maestro dependency updates:

  • runtime-coreclr superpmi-asmdiffs
  • runtime-libraries enterprise-linux

The dependency update PRs then cannot be auto-merged:

image

We cannot ignore skipped checks on Maestro side because someone could just add ignore paths to all pipelines and push a check-less PR through.

We have configured the repository policies to this:

https://github.com/dotnet/runtime @ main
- Merge Policies:
  AllChecksSuccessful
    ignoreChecks =
                   [
                     "WIP",
                     "license/cla",
                     "runtime-coreclr superpmi-asmdiffs",
                     "runtime-libraries enterprise-linux"
                   ]
  NoRequestedChanges

In case we start running these pipelines for eng/common, Versions.props or Versions.Details.xml changes, we should remove these checks from the ignored column.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Feb 2, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Following pipelines are skipped for Maestro dependency updates:

  • runtime-coreclr superpmi-asmdiffs
  • runtime-libraries enterprise-linux

The dependency update PRs then cannot be auto-merged:

image

We have configured the repository policies to this:

https://github.com/dotnet/runtime @ main
- Merge Policies:
  AllChecksSuccessful
    ignoreChecks =
                   [
                     "WIP",
                     "license/cla",
                     "runtime-coreclr superpmi-asmdiffs",
                     "runtime-libraries enterprise-linux"
                   ]
  NoRequestedChanges

In case we start running these pipelines for eng/common, Versions.props or Versions.Details.xml changes, we should remove these checks from the ignored column.

Author: premun
Assignees: premun
Labels:

area-Infrastructure

Milestone: -

@safern safern merged commit 6fc39ae into dotnet:main Feb 2, 2022
@premun premun deleted the prvysoky/ignored-checks branch February 3, 2022 08:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants