-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Run debugger test in codespace #64746
[wasm][debugger] Run debugger test in codespace #64746
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
The change to the Dockerfile looks good to me. I wonder if you change to the test harness startup file triggered the failures on CI. |
Some of these failures were due to missing helix queues, which is fixed on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we print out a diagnostic message saying we've disabled sandboxes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enables running debugger tests with no additional package installations.
Running a sample debugger test:
Changes in this PR:
Recommendation:
use at least 8 core VM. For smaller sizes you can encounter an error:
Less than 64MB of free space in temporary directory for shared memory files
.Test that always fail in codespace on main (different than typically):
Possible workaround if --no-sanbox was in some point inconvenient -> adding to devcontainer.json:
in this solution bigger VM is also needed because of threads' crashes:
unless we use the VM with 16 core or 8 core.