Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing EventLogSession.GetProviderNames test #64780

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Disable failing EventLogSession.GetProviderNames test #64780

merged 3 commits into from
Feb 24, 2022

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 4, 2022

See #64153

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned sbomer Feb 4, 2022
@runfoapp runfoapp bot mentioned this pull request Feb 4, 2022
Closed
@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-eventlog
See info in area-owners.md if you want to be subscribed.

Issue Details

See #64153

Author: sbomer
Assignees: sbomer
Labels:

area-System.Diagnostics.EventLog
Milestone: -

@carlossanlop
Copy link
Member

@tarekgh any chance you could help take a look at this one?

@tarekgh
Copy link
Member

tarekgh commented Feb 24, 2022

@sbomer I am seeing this is failing on x86 too. Why are we disabling this test on x64 only?

@sbomer
Disable failing EventLogSession.GetProviderNames test
e64ca11
@sbomer
PR feedback
dd65331 
- Disable on x86 too
- Combine into one condition
@sbomer sbomer force-pushed the disableProviderNameTests branch from 2ef8953 to dd65331 Compare February 24, 2022 17:08
@sbomer
Copy link
Member Author

sbomer commented Feb 24, 2022

@sbomer I am seeing this is failing on x86 too. Why are we disabling this test on x64 only?

IIRC originally I saw it failing only on x64 and I wasn't sure if it was a recurring failure. Now that we are seeing it more often and on x86 I updated the PR to disable it on both architectures. Thanks!

tarekgh
tarekgh approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbomer

@sbomer sbomer merged commit a82d92c into dotnet:main Feb 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
@sbomer sbomer deleted the disableProviderNameTests branch November 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees

@sbomer sbomer

Labels
area-System.Diagnostics.EventLog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbomer @carlossanlop @tarekgh @jeffhandley