-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up several special tests under JIT/Methodical #64837
Conversation
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsSeveral IL tests listed their classes twice - presumably once as a Thanks Tomas /cc @dotnet/jit-contrib
|
Tagging subscribers to this area: @hoyosjs Issue DetailsSeveral IL tests listed their classes twice - presumably once as a Thanks Tomas /cc @dotnet/jit-contrib
|
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Several IL tests listed their classes twice - presumably once as a 'declaration' and ther second time as the 'definition'. Apart from the fact that this causes trouble in my semi-automatic IL rewriter, I don't see any reason for keeping this moving forward as it just clutters the files and complicates their maintenance. I also found one remaining test with main accepting command-line arguments (previously overlooked due to lowercase m). Thanks Tomas Make stringintern test classes public Make ExplicitLayout owner class public
43a71ab
to
00bc78b
Compare
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.
Thanks
Tomas
/cc @dotnet/jit-contrib