Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up several special tests under JIT/Methodical #64837

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

trylek
Copy link
Member

@trylek trylek commented Feb 5, 2022

Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.

Thanks

Tomas

/cc @dotnet/jit-contrib

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 5, 2022
@ghost ghost assigned trylek Feb 5, 2022
@ghost
Copy link

ghost commented Feb 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.

Thanks

Tomas

/cc @dotnet/jit-contrib

Author: trylek
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@trylek trylek added area-Infrastructure-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 5, 2022
@ghost
Copy link

ghost commented Feb 5, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Several IL tests listed their classes twice - presumably once as a
'declaration' and a second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m) and I manually made
the stringintern test classes public as the ILTransform tool now has
trouble understanding them due to the presence of preprocessor
directives.

Thanks

Tomas

/cc @dotnet/jit-contrib

Author: trylek
Assignees: trylek
Labels:

area-Infrastructure-coreclr

Milestone: -

@trylek trylek added this to the 7.0.0 milestone Feb 5, 2022
@trylek
Copy link
Member Author

trylek commented Feb 7, 2022

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek trylek closed this Feb 8, 2022
@trylek trylek reopened this Feb 8, 2022
@trylek
Copy link
Member Author

trylek commented Feb 8, 2022

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Several IL tests listed their classes twice - presumably once as a
'declaration' and ther second time as the 'definition'. Apart from
the fact that this causes trouble in my semi-automatic IL rewriter,
I don't see any reason for keeping this moving forward as it just
clutters the files and complicates their maintenance. I also found
one remaining test with main accepting command-line arguments
(previously overlooked due to lowercase m).

Thanks

Tomas

Make stringintern test classes public

Make ExplicitLayout owner class public
@trylek trylek force-pushed the JIT-Methodical-specials branch from 43a71ab to 00bc78b Compare February 8, 2022 23:45
@trylek
Copy link
Member Author

trylek commented Feb 8, 2022

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek trylek merged commit 1a2e3c3 into dotnet:main Feb 9, 2022
@trylek trylek deleted the JIT-Methodical-specials branch February 9, 2022 23:26
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants