-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SSL platform detection #64923
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThis is platform detection part from #60163 (that is replaced by different change)
|
/azp runtime-extra-platforms |
Command 'runtime-extra-platforms' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
While the tests still failed with #64944, SSL & HTTP runs seems clean on Windows. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1814919688 |
@wfurt backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: CI matrix change: add Windows Server 2022
Using index info to reconstruct a base tree...
M eng/pipelines/libraries/helix-queues-setup.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/helix-queues-setup.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/helix-queues-setup.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 CI matrix change: add Windows Server 2022
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@wfurt, seems like we need to backport it manually |
yes, this is the main change that gives visibility to availably of given protocol version. I should probably be able to craft the 6.0 version today. |
* CI matrix change: add Windows Server 2022 * Add registry check for ssl3 - tls1.2 tests * Disable TLS1.3 on framework code * Fix typo * revert queue change Co-authored-by: Jan Jahoda <jajahoda@microsoft.com>
This is platform detection part from #60163 (that is replaced by different change)
It added more generic support detection for Windows. No production code changes.