Make System.Math/MathF.Truncate an intrinsic #65014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsMakes Truncate emit round with truncate mode on xarch and frintz on aarch64. Based off current handling for Ceiling. Fixes #56931
|
MichalPetryka
force-pushed
the
intrinsic-truncate
branch
from
3c5c520 to
ab55a47
Compare
|
@tannergooding asked me to revert the fcalls and add back the managed method instead on discord, will handle it tomorrow. |
MichalPetryka
force-pushed
the
intrinsic-truncate
branch
from
ab55a47 to
5e1ff68
Compare
MichalPetryka
force-pushed
the
intrinsic-truncate
branch
from
5e1ff68 to
196eafe
Compare
|
Test failures seem unrelated, marking as ready for review. |
tannergooding
approved these changes
Feb 11, 2022
|
CC. @dotnet/jit-contrib; Community PR needs secondary sign-off |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Truncate emit round with truncate mode on xarch and frintz on aarch64.
Based off current handling for Ceiling.
Fixes #56931