Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [wasm][debugger] Fix (chrome|edge)://inspect for the debug proxy #65219

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 11, 2022

Backport of #65216 to release/6.0

The chrome://inspect CDP logic is rejecting /json responses that don't include the content length in the response, this fixes that and allows chrome://inspect to connect to the proxy properly

/cc @lewing

Customer Impact

Without this change the official browser debugger front end is no longer able to connect properly to proxy preventing customers from using chrome or edge as the debugger frontend.

Testing

Manual testing.

Risk

Very low. Simply sets the content-length in the response header

@ghost
Copy link

ghost commented Feb 11, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #65216 to release/6.0

/cc @lewing

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@lewing lewing added the Servicing-consider Issue for next servicing release review label Feb 11, 2022
@lewing lewing added this to the 6.0.4 milestone Feb 11, 2022
@lewing lewing added the arch-wasm WebAssembly architecture label Feb 12, 2022
@ghost
Copy link

ghost commented Feb 12, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #65216 to release/6.0

The chrome://inspect CDP logic is rejecting /json responses that don't include the content length in the response, this fixes that and allows chrome://inspect to connect to the proxy properly

/cc @lewing

Customer Impact

Without this change the official browser debugger front end is no longer able to connect properly to proxy preventing customers from using chrome or edge as the debugger frontend.

Testing

Manual testing.

Risk

Very low. Simply sets the content-length in the response header

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Debugger-mono

Milestone: 6.0.4

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 15, 2022
@lewing
Copy link
Member

lewing commented Feb 24, 2022

can someone with the appropriate authorization please merge this?

@carlossanlop
Copy link
Member

PR has sign-off, the servicing-approved label applied, and the CI is passing. Ready to merge.

@carlossanlop carlossanlop merged commit 51ecbf3 into release/6.0 Mar 8, 2022
@carlossanlop carlossanlop deleted the backport/pr-65216-to-release/6.0 branch March 8, 2022 20:55
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants