[interp] Use dynamic method's assembly when getting a native wrapper #65320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic method `klass` is just System.Object, so its image is always corelib. As a result, we incorrectly pick up the DisableRuntimeMarshalling attribute from CoreLib. Fixes dotnet#65304 The corresponding change to the JIT+AOT was done in dotnet@ac825ab
ghost
assigned 
|
Tagging subscribers to this area: @BrzVlad Issue DetailsThe dynamic method Fixes #65304 The corresponding change to the JIT+AOT was done in
|
|
/azp run runtime-staging |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Feb 14, 2022
|
Wasm failures are #65242 |
vargaz
approved these changes
Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic method
klassis just System.Object, so its image is always corelib. As a result, we incorrectly pick up theDisableRuntimeMarshallingattribute from CoreLib.Fixes #65304
The corresponding change to the JIT+AOT was done in
ac825ab