[release/6.0] Remove Unused Encoding on UriHelper #65330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This field was a left-over artifact from conflicts between the commits: - 70c070e - e53e543 In profiling the startup of a Maui Android app, this initialization is pulling in UTF32 and Latin1 encodings. The profile indicates this accounts for 7ms (roughly 1%). Removing this unnecessary field eliminates 7ms in a Maui App's InitializeComponent.
|
Tagging subscribers to this area: @dotnet/ncl |
MihaZupan
approved these changes
Feb 14, 2022
rbhanda
added
Servicing-approved
|
Failure is #61524. Merging |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #65326 to release/6.0
/cc @eerhardt
Customer Impact
Initializing this unused field was accounting for about 1% of startup costs of a
dotnet new mauiandroid app (~7ms) according to profiling.Before
After
Testing
I profiled a Maui Android app before and after this change, ensuring InitializeComponent was faster.
Existing CI tests pass.
Risk
Very low. Removing an internal static field.