Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Remove Unused Encoding on UriHelper #65330

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 14, 2022

Backport of #65326 to release/6.0

/cc @eerhardt

Customer Impact

Initializing this unused field was accounting for about 1% of startup costs of a dotnet new maui android app (~7ms) according to profiling.

Before
image

After
image

Testing

I profiled a Maui Android app before and after this change, ensuring InitializeComponent was faster.
Existing CI tests pass.

Risk

Very low. Removing an internal static field.

This field was a left-over artifact from conflicts between the commits:
- 70c070e
- e53e543

In profiling the startup of a Maui Android app, this initialization is pulling in UTF32 and Latin1 encodings. The profile indicates this accounts for 7ms (roughly 1%). Removing this unnecessary field eliminates 7ms in a Maui App's InitializeComponent.
@ghost
Copy link

ghost commented Feb 14, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #65326 to release/6.0

/cc @eerhardt

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@eerhardt eerhardt added the Servicing-consider Issue for next servicing release review label Feb 14, 2022
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 15, 2022
@rbhanda rbhanda added this to the 6.0.4 milestone Feb 15, 2022
@ericstj
Copy link
Member

ericstj commented Mar 10, 2022

Failure is #61524. Merging

@ericstj ericstj merged commit 1f89b1b into release/6.0 Mar 10, 2022
@eerhardt eerhardt deleted the backport/pr-65326-to-release/6.0 branch March 10, 2022 18:29
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants