Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder for package authoring #65480

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

danmoseley
Copy link
Member

The backport bot makes it easy to overlook the requirement to add package authoring when code ships in its own package.

Add some reminders.

@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

The backport bot makes it easy to overlook the requirement to add package authoring when code ships in its own package.

Add some reminders.

Author: danmoseley
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost ghost assigned danmoseley Feb 17, 2022
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this covers PRs that are created via the backport bot, we should add some sort of automation for those cases, I was discussing that with @ericstj and @carlossanlop

Maybe even set CI to red

@danmoseley
Copy link
Member Author

Can you clarify - automation of what kind? When would we see things to red?

@danmoseley
Copy link
Member Author

Btw the servicing PR template will presumably have to be backported itself to be any use.

@danmoseley danmoseley merged commit f8fb217 into dotnet:main Feb 17, 2022
@danmoseley
Copy link
Member Author

/backport to release/6.0

@danmoseley danmoseley deleted the servicing.reminder branch February 17, 2022 03:34
@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1856602282

@github-actions
Copy link
Contributor

@danmoseley an error occurred while backporting to release/6.0, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@safern
Copy link
Member

safern commented Feb 17, 2022

Can you clarify - automation of what kind? When would we see things to red?

Identify if a servicing change contains a change inside an OOB package and comment automatically or fail the build letting the author to include packaging changes, as not all servicing changes go through the backport bot nor use the PR template, that would help a lot.

@danmoseley
Copy link
Member Author

Looks like GitHub prevents a workflow changing a workflow


HEAD -> backport/pr-65480-to-release/6.0 (refusing to allow a GitHub App to create or update workflow `.github/workflows/backport.yml` without `workflows` permission)

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants