-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reminder for package authoring #65480
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThe backport bot makes it easy to overlook the requirement to add package authoring when code ships in its own package. Add some reminders.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this covers PRs that are created via the backport bot, we should add some sort of automation for those cases, I was discussing that with @ericstj and @carlossanlop
Maybe even set CI to red
Can you clarify - automation of what kind? When would we see things to red? |
Btw the servicing PR template will presumably have to be backported itself to be any use. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1856602282 |
@danmoseley an error occurred while backporting to release/6.0, please check the run log for details! The process '/usr/bin/git' failed with exit code 1 |
Identify if a servicing change contains a change inside an OOB package and comment automatically or fail the build letting the author to include packaging changes, as not all servicing changes go through the backport bot nor use the PR template, that would help a lot. |
Looks like GitHub prevents a workflow changing a workflow
|
The backport bot makes it easy to overlook the requirement to add package authoring when code ships in its own package.
Add some reminders.