-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch over JIT/Methodical tests to run using merged wrappers #65597
Conversation
Tagging subscribers to this area: @hoyosjs Issue Detailsfyi @jkoritzinsky
|
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Two things that immediately popped out to me:
|
@BruceForstall - once I pass initial outerloop validation on the change, I plan to start triggering Crossgen2 and stress runs to further validate the change. Please let me know which pipelines you find the most important to start with. |
@jkoritzinsky - thanks for your immediate feedback. I believe my change should include removal of the wrappers under Array you previously added, if it doesn't, it will likely fail the build. |
Hmm, in fact it won't fail the build, it only fails local test run because the Python code for producing the summary table hits a duplicate dictionary key. I'm not sure whether that's exercised in lab pipeline runs, I guess we'll see in an hour or two. |
Yes, it looks like they have been removed. GitHub's diff was not showing it to me due to the number of changed files, but I validated in the GitHub Codespaces view that the Range merged wrappers are gone. |
@jkoritzinsky - while this change is still WIP, I have tried to maintain some consistency w.r.t. its contents; I believe the particular bit we're discussing here should be covered in the commit Thanks Tomas |
First would be |
@jkoritzinsky - Hehe, I was curious why we're not observing the removal of the range_d and range_r projects you previously added. Turns out GitHub decided the newly added Methodical_* projects are their renames. |
Ah Git rename detection. It always kicks in when you don't need it to and rarely kicks in when you actually want it to |
One additional bit of debt in this change is the lack of issues.targets migration regarding the tests involved; I plan to work on that next. |
/azp run runtime-coreclr outerloop |
Pull request contains merge conflicts. |
49eddbd
to
f5beccb
Compare
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
ae7da2f
to
45755b9
Compare
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr jitstress |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
/azp run runtime-extra-platforms |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
Based on Andrew's suggestion I have experimentally combined this change with a subtle tweak to |
Hmm, in fact I don't think there's any chance this might work as the script is not actually exercised in the lab pipelines at all; instead I'll add targeted instrumentation letting us see at runtime whether the event log has been activated (in some other manner) directly in the offending runs. |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
I have verified that in the latest r2r-extra run I no longer see the hangs; some unrelated tests failed and two merged wrappers crashed on a runtime JIT assertion that is a known issue according to Bruce. I plan to merge this in after retesting unless some new catastrophic failure appears. |
Split Methodical_d and Methodical_r in two parts Remove JIT/Methodical entries from testgrouping.proj
fyi @jkoritzinsky