Fix clash between tentative method optimizations #66145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we were in the situation of the newly added test, we would try to generate method body on the abstract class. Such method body is not actually reachable. Saves ~500 bytes on a hello world. Fixes a compiler assert (that might be more serious sometimes).
ghost
assigned 
Turns out this optimization is a bit more complicated. Adding a test case for when it didn't do the right thing, in case we want to come back to it later.
MichalStrehovsky
force-pushed
the
dependencyanl
branch
from
8ebfd47 to
99f0783
Compare
|
This pull request pretty much became a rollback of dotnet/runtimelab#658 with a regression test to make sure if dotnet/runtimelab#658 is reintroduced, we do it properly. |
jkotas
approved these changes
Mar 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request pretty much became a rollback of dotnet/runtimelab#658 with a regression test to make sure if dotnet/runtimelab#658 is reintroduced, we do it properly.
When we were in the situation of the newly added test, we would try to generate method body on the abstract class. Such method body is not actually reachable.Saves 500 bytes on a hello world. Fixes a compiler assert (that might be more serious sometimes).