Don't add TestLibrary as a reference to all runtime tests #66157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was tagging several architecture-dependent runtime tests with the ConditionalFact attribute, I added CoreCLRTestLibrary as a general reference. This started causing timeouts in Mono AOT tests because the library needs to be compiled many times. As there's only a small number of architecture-dependent tests, I have modified the change so that the test library is only added explicitly to architecture-dependent tests. Fixes: dotnet#66083 Thanks Tomas
ghost
assigned 
|
Tagging subscribers to this area: @directhex Issue DetailsWhen I was tagging several architecture-dependent runtime tests Fixes: #66083 Thanks Tomas /cc @dotnet/runtime-infrastructure
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fanyang-mono
approved these changes
Mar 3, 2022
jkoritzinsky
approved these changes
Mar 3, 2022
SamMonoRT
approved these changes
Mar 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was tagging several architecture-dependent runtime tests
with the ConditionalFact attribute, I added CoreCLRTestLibrary
as a general reference. This started causing timeouts in Mono AOT
tests because the library needs to be compiled many times.
As there's only a small number of architecture-dependent tests,
I have modified the change so that the test library is only added
explicitly to architecture-dependent tests.
Fixes: #66083
Thanks
Tomas
/cc @dotnet/runtime-infrastructure