Rename GeneratedDllImportAttribute -> LibraryImportAttribute
#66307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue Detailsnull
|
AraHaan
reviewed
Mar 7, 2022
src/libraries/Common/src/System/Runtime/InteropServices/LibraryImportAttribute.cs
Show resolved
Hide resolved
elinor-fung
force-pushed
the
renameAttribute
branch
from
638e202 to
2d90838
Compare
elinor-fung
force-pushed
the
renameAttribute
branch
from
2d90838 to
d2eb353
Compare
|
Failures are unrelated. |
AaronRobinsonMSFT
approved these changes
Mar 9, 2022
...raries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CodeSnippets.cs
Outdated
Show resolved
Hide resolved
…rtGenerator.UnitTests/CodeSnippets.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>
|
Merging - last commit was comment-only. |
deeprobin
added a commit
to deeprobin/runtime
that referenced
this pull request
Mar 10, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
GeneratedDllImportAttribute->LibraryImportAttribute.After this,
LibraryImportAttributeshould match the approved API. And then we can actually add/expose it in libraries.Contributes to #46822