[main] Update dependencies from dotnet/roslyn-analyzers

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

• Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
• Build: 20220324.1
• Date Produced: March 24, 2022 10:29:51 PM UTC
• Commit: 40702da4e57358b9165bdf697f044826d40963bc
• Branch: refs/heads/main

• Updates:
  • Microsoft.CodeAnalysis.NetAnalyzers: from 7.0.0-preview1.22166.1 to 7.0.0-preview1.22174.1

[danmoseley]

@jkoritzinsky these are now causing a warning. Does this assembly need DisableRuntimeMarshalling.cs?

        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        internal delegate uint SetContextDelegate(
            SafeHandle handle,
            IntPtr context);

[jkoritzinsky]

I was working on this in another DARC update PR. I'll port my changes over here and get this one passing and ready to merge.

[danmoseley]

Just curious, I see many assemblies have DisableRuntimeMarshalling currently. Does this mean none of those are suitable for no-JIT targets? Or that's just a work in progress?

[jkoritzinsky]

DisableRuntimeMarshalling is a feature we added to support source-generated interop. The build failures we're seeing here are on places that will likely fail at runtime due to which features are disabled when the attribute is applied that I missed when initially applying the attribute (an analyzer that warns on places likely to break was added in Roslyn-analyzers to help catch failures at build time).

[danmoseley]

System.ArgumentNullException : Value cannot be null. (Parameter 'packageStream')


Stack trace
   at NuGet.Packaging.PackageExtractor.ExtractPackageAsync(String source, Stream packageStream, PackagePathResolver packagePathResolver, PackageExtractionContext packageExtractionContext, CancellationToken token, Guid parentId)
   at Microsoft.CodeAnalysis.Testing.ReferenceAssemblies.ResolveCoreAsync(String language, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs:line 358
   at Microsoft.CodeAnalysis.Testing.ReferenceAssemblies.ResolveAsync(String language, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs:line 197
   at Microsoft.CodeAnalysis.Testing.ReferenceAssemblies.ResolveAsync(String language, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs:line 174
   at LibraryImportGenerator.UnitTests.TestUtils.ResolveReferenceAssemblies(ReferenceAssemblies referenceAssemblies) in /_/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/TestUtils.cs:line 228
   at LibraryImportGenerator.UnitTests.TestUtils.GetReferenceAssemblies(TestTargetFramework targetFramework) in /_/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/TestUtils.cs:line 174
   at LibraryImportGenerator.UnitTests.TestUtils.CreateCompilation(SyntaxTree[] sources, TestTargetFramework targetFramework, OutputKind outputKind) in /_/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/TestUtils.cs:line 132
   at LibraryImportGenerator.UnitTests.AdditionalAttributesOnStub.SkipLocalsInitOnDownlevelTargetFrameworks(TestTargetFramework targetFramework, Boolean expectSkipLocalsInit) in /_/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AdditionalAttributesOnStub.cs:line 143
--- End of stack trace from previous location ---

[jkoritzinsky]

That failure is dotnet/roslyn-sdk#974

[jkoritzinsky]

@danmoseley on a re-run of that leg, the test didn't fail. Can you take a quick review of this PR so we can get this in?