Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group 9] Enable nullable annotations for Microsoft.Extensions.Hosting.Systemd #67513

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Apr 3, 2022

Fixes #43605

It's not mentioned in 43605, but it exists, so why not?

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 3, 2022
@ghost
Copy link

ghost commented Apr 3, 2022

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

It's not mentioned in 43605, but it exists, so why not?

Author: maxkoshevoi
Assignees: -
Labels:

area-Extensions-Hosting

Milestone: -

@eerhardt
Copy link
Member

eerhardt commented Apr 4, 2022

It's not mentioned in 43605, but it exists, so why not?

Thanks for calling this out. I've added it and Hosting.WindowsServices to the list.

@maxkoshevoi maxkoshevoi marked this pull request as ready for review April 16, 2022 05:38
@maxkoshevoi
Copy link
Contributor Author

Seems like this needs a suppression file

@eerhardt
Copy link
Member

Seems like this needs a suppression file

It was just simpler to use a ! operator here in one place.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt merged commit 9849af2 into dotnet:main Apr 18, 2022
directhex pushed a commit to directhex/runtime that referenced this pull request Apr 21, 2022
…ng.Systemd` (dotnet#67513)

Fix dotnet#43605

* Annotate

* Fix API compat check by removing MemberNotNullWhen attribute.

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Hosting community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotate Microsoft.Extensions.* assemblies for nullable reference types
2 participants