improve Tls12 detection on Windows7 #67935
Conversation
wfurt
added
area-System.Net.Security
test-enhancement
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsProtocol detection is trickier on Window7. The To make Tls12 working DisabledByDefault also must be set to 0. We will need another Helix change to get Tls12 truly working. I did private test run with fixes #67687 and replaces #67904
|
| return GetProtocolSupportFromWindowsRegistry(SslProtocols.Tls11, defaultProtocolSupport); | ||
| if (IsWindows7) | ||
| { | ||
| return GetProtocolSupportFromWindowsRegistry(SslProtocols.Tls11, false, true); |
There was a problem hiding this comment.
Nit: can you name these bools? It's hard to tell without that what they mean.
There was a problem hiding this comment.
updated. I also updated many comments as the logic is getting more complicated.
|
btw we will need to pick this if we see Windows 7 failures in release branches @carlossanlop |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Resolve System.Net.Security.Tests.LoggingTest SkipTestException failure (#65322) * improve Tls12 detection on Windows7 (#67935) * disable Tls 1.0 and 1.1 tests on new Windows (#68083) * Don't throw from RemoteExecutor on SkipTestExceptions (#65105) * update SSL tests to deal better with disabled protocols (#65120) * update SSL tests to deal better with disabled protocols * Improve detection of Null encryption on Windows * update expectation for Mismatched protocols * update detection * wrap win32 exception * update ProtocolMismatchData sets * remove debug print * final cleanup * generate mismatch data * avoid SslProtocols.Default Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
ghost
locked as resolved and limited conversation to collaborators
Protocol detection is trickier on Window7. The
Enabledis not sufficient and recent Helix updated confused our platform detection.To make Tls12 working DisabledByDefault also must be set to 0.
We will need another Helix change to get Tls12 truly working. I did private test run with
DisabledByDefault=0and all tests could pass (including outer loop)fixes #67687 and replaces #67904
fixes #67712